https://bugs.kde.org/show_bug.cgi?id=373416

Heinz Wiesinger <ppr...@liwjatan.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.3.0
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |v-php/488b24571de92a7ed7c9c
                   |                            |55365384c8c9295bab5

--- Comment #1 from Heinz Wiesinger <ppr...@liwjatan.at> ---
Git commit 488b24571de92a7ed7c9c55365384c8c9295bab5 by Heinz Wiesinger.
Committed on 17/08/2018 at 09:53.
Pushed by wiesinger into branch '5.3'.

Improve resolution of namespaced identifiers.

Summary:
The PST has problems matching qualified identifiers explicitely
set to global with declarations. To work around this we normalize
the namespaced identifier to be always absolute.

This means that namespace resolution inside findDeclarationImportHelper
should be correct now, but may need several calls to find the declaration
we're looking for according to the correct rules. Unfortunately, the rules
are different for classes, use declarations, functions, constants, etc.
That's why it really needs to be call-side decision on what fallbacks can
or can't be used.
FIXED-IN: 5.3.0

Reviewers: brauch

Reviewed By: brauch

Subscribers: brauch, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D14839

M  +7    -1    duchain/builders/contextbuilder.cpp
M  +1    -1    duchain/builders/contextbuilder.h
M  +18   -2    duchain/builders/declarationbuilder.cpp
M  +5    -2    duchain/builders/typebuilder.cpp
M  +25   -1    duchain/builders/usebuilder.cpp
M  +9    -1    duchain/expressionvisitor.cpp
M  +15   -18   duchain/helper.cpp
M  +5    -0    duchain/helper.h
M  +37   -0    duchain/tests/duchain_multiplefiles.cpp
M  +1    -0    duchain/tests/duchain_multiplefiles.h

https://commits.kde.org/kdev-php/488b24571de92a7ed7c9c55365384c8c9295bab5

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to