https://bugs.kde.org/show_bug.cgi?id=381080
Dominik Haumann <dhaum...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://cgit.kde.org/ktexte |https://commits.kde.org/kte
|ditor.git/commit/?id=c90064 |xteditor/c90064799dfb9afa7e
|799dfb9afa7e5da20eb15856f48 |5da20eb15856f486a171a3
|6a171a3 |
--- Comment #6 from Dominik Haumann <dhaum...@kde.org> ---
Git commit c90064799dfb9afa7e5da20eb15856f486a171a3 by Dominik Haumann.
Committed on 14/08/2018 at 16:24.
Pushed by dhaumann into branch 'master'.
Fix crash when replacing \n around empty lines
Summary:
The problem is that QString("").startsWith("") returns false.
Similarly, QString("").endsWith("") also returns false.
However, the code previously was assuming that both cases return true.
This is now fixed, and verified through unit tests.
This deprecates patch D6473
Test Plan: make && make test
Reviewers: jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff
Reviewed By: cullmann
Subscribers: kwrite-devel, kde-frameworks-devel
Tags: #kate, #frameworks
Differential Revision: https://phabricator.kde.org/D14847
M +40 -1 autotests/src/searchbar_test.cpp
M +3 -0 autotests/src/searchbar_test.h
M +7 -2 src/search/kateplaintextsearch.cpp
https://commits.kde.org/ktexteditor/c90064799dfb9afa7e5da20eb15856f486a171a3
--
You are receiving this mail because:
You are watching all bug changes.
