https://bugs.kde.org/show_bug.cgi?id=397154
--- Comment #14 from Michael Pyne <mp...@kde.org> ---
I'm not a fan of changing the enum classes if we can avoid it, since that may
have impact on C++-using code.
I have an Ubuntu-based container where the build also completes successfully so
I don't think is a matter of impossibility with latest sip/PyQt5.
Regardless I've come up with a patch to make the bindings optional for now, and
maybe that's the least-worst solution to at least getting things to build for
those who don't need the bindings.
You'd need to pass the -DGENERATE_PYTHON_MODULES=OFF option when running cmake
since the option defaults to being set.
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5bd07ed..b860afd 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -27,6 +27,9 @@ include(KDECMakeSettings)
option(BUILD_QCH "Build API documentation in QCH format (for e.g. Qt
Assistant, Qt Creator & KDevelop)" OFF)
add_feature_info(QCH ${BUILD_QCH} "API documentation in QCH format (for e.g.
Qt Assistant, Qt Creator & KDevelop)")
+option(GENERATE_PYTHON_MODULES "Build Python bindings for KCoreAddons
libraries, if needed dependencies are available" ON)
+add_feature_info(PYTHON_BINDING ${GENERATE_PYTHON_MODULES} "Generates Python
bindings for KCoreAddons libraries, if needed dependencies are available")
+
set(REQUIRED_QT_VERSION 5.8.0)
find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED Core)
diff --git a/src/lib/CMakeLists.txt b/src/lib/CMakeLists.txt
index 573d6e3..8f0ff3a 100644
--- a/src/lib/CMakeLists.txt
+++ b/src/lib/CMakeLists.txt
@@ -205,7 +205,9 @@ ecm_generate_headers(KCoreAddons_HEADERS
REQUIRED_HEADERS KCoreAddons_HEADERS
)
-find_package(PythonModuleGeneration)
+if (GENERATE_PYTHON_MODULES)
+ find_package(PythonModuleGeneration)
+endif ()
if (PythonModuleGeneration_FOUND)
ecm_generate_python_binding(
--
You are receiving this mail because:
You are watching all bug changes.
