https://bugs.kde.org/show_bug.cgi?id=396666
Eike Hein <h...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/pla
| |sma-desktop/1cb71a2cca8a465
| |12f5ac0cb03da268dde8d9c7d
Resolution|--- |FIXED
--- Comment #3 from Eike Hein <h...@kde.org> ---
Git commit 1cb71a2cca8a46512f5ac0cb03da268dde8d9c7d by Eike Hein.
Committed on 01/08/2018 at 10:43.
Pushed by hein into branch 'Plasma/5.12'.
Fix bad model hygiene in Positioner::move()
Summary:
Don't change the proxy maps prior to insert/remove transactions so
rowCount() at transaction start time matches the count passed into
the method. The old code hits an ASSERT in Qt 5.11 otherwise.
Care is taken not to emit dataChanged() in the middle of another
transaction.
Also cleaned up vestiges of caching lastRow(): This cache was
evicted all over the places but never actually filled anymore, so
maybe we don't need it.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14243
M +32 -21 containments/desktop/plugins/folder/positioner.cpp
M +0 -2 containments/desktop/plugins/folder/positioner.h
https://commits.kde.org/plasma-desktop/1cb71a2cca8a46512f5ac0cb03da268dde8d9c7d
--
You are receiving this mail because:
You are watching all bug changes.
