https://bugs.kde.org/show_bug.cgi?id=386034
--- Comment #3 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 3215716e422ef1d6dc93d83a25c655095bb0ba6d by Henrik Fehlauer.
Committed on 08/07/2018 at 22:45.
Pushed by rkflx into branch 'master'.
Do not allow to drag an image onto itself
Summary:
The combination of 131d25855e11 and 984b9737f079 led to the user being
able to drag an image in {nav View} mode and immediately drop it again.
The drag cursor implied Gwenview allowed this kind of operation, while
actually nothing would happen as the URL did not change.
To prevent confusion, we do not allow to drop the image in that
situation anymore. It is still possible to drop multiple images which
include the current image, so a future patch could implement switching
to {nav Compare} mode in that case.
As a side effect a small visual bug is fixed: When moving very slowly
while initiating a drag, the `ForbiddenCursor` would appear briefly
until you moved the mouse further along and the actual drag cursor
appeared. With the patch applied, the cursor will always keep being set
to `ForbiddenCursor`, preventing any flickering.
Test Plan:
Slowly start to drag an image in {nav View} mode. The cursor should
indicate no dropping is allowed.
Reviewers: #gwenview, huoni
Reviewed By: #gwenview, huoni
Subscribers: huoni
Differential Revision: https://phabricator.kde.org/D13724
M +9 -1 lib/documentview/documentview.cpp
https://commits.kde.org/gwenview/3215716e422ef1d6dc93d83a25c655095bb0ba6d
--
You are receiving this mail because:
You are watching all bug changes.
