https://bugs.kde.org/show_bug.cgi?id=395191
Bug ID: 395191
Summary: WebViewTest::loadSignalsChangePageTest() Compared
values are not the same (qt-5.11.0)
Product: Falkon
Version: unspecified
Platform: unspecified
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: now...@gmail.com
Reporter: zarniwh...@ntlworld.com
Target Milestone: ---
********* Start testing of WebViewTest *********
Config: Using QtTest library 5.11.0, Qt 5.11.0 (x86_64-little_endian-lp64
shared (dynamic) release build; by GCC 8.1.0)
PASS : WebViewTest::initTestCase()
FAIL! : WebViewTest::loadSignalsChangePageTest() Compared values are not the
same
Actual (((loadFinishedSpy.count()))): 2
Expected (loadFinishedEmitCount) : 1
Loc: [/tmp/falkon-3.0.1/autotests/webviewtest.cpp(87)]
PASS : WebViewTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 15276ms
********* Finished testing of WebViewTest *********
<end of output>
Test time = 15.70 sec
----------------------------------------------------------
Test Failed.
"falkon-webviewtest" end time: Jun 09 20:42 BST
"falkon-webviewtest" time elapsed: 00:00:15
Further comments:
If falkon has not yet been installed on a qt-5.11.0 system, 6 out of 10 of the
tests fail. But after installation on at qt-5.11.0 system only this test fails.
On a slightly older system, with qt-5.10 and falkon-3.0.0 already installed,
all 10 tests passed.
Diffing falkon-3.0.0 to 3.0.1 produced the following suspicious change (the
change to 5.11 is not suspicious, the reversal of 2 : 1 to 1 : 2 is):
index a21e693..40b0a57 100644
--- a/falkon-3.0.0/autotests/webviewtest.cpp
+++ b/falkon-3.0.1/autotests/webviewtest.cpp
@@ -82,7 +82,7 @@ void WebViewTest::loadSignalsChangePageTest()
view.setPage(page2);
// WebPage: Workaround for broken load started/finished signals in
QtWebEngine 5.10
- const int loadFinishedEmitCount = qstrncmp(qVersion(), "5.10.", 5) == 0 ?
2 : 1;
+ const int loadFinishedEmitCount = qstrncmp(qVersion(), "5.11.", 5) == 0 ?
1 : 2;
QTRY_COMPARE(loadFinishedSpy.count(), loadFinishedEmitCount);
QCOMPARE(loadStartedSpy.count(), 0);
Editing that line to
const int loadFinishedEmitCount = qstrncmp(qVersion(), "5.11.", 5) == 0 ? 2
: 1;
all the tests pass on the 5.11.0 system.
--
You are receiving this mail because:
You are watching all bug changes.
