https://bugs.kde.org/show_bug.cgi?id=381173

Friedrich W. H. Kossebau <kosse...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |5.12.6
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |plasma-addons/6ce58880151da
                   |                            |d9e0adb3607087de12bca65a6cc
         Resolution|---                         |FIXED

--- Comment #20 from Friedrich W. H. Kossebau <kosse...@kde.org> ---
Git commit 6ce58880151dad9e0adb3607087de12bca65a6cc by Friedrich W. H.
Kossebau.
Committed on 23/05/2018 at 15:41.
Pushed by kossebau into branch 'Plasma/5.12'.

[Timer applet] Fix double speed countdown & commands run multiple times

Summary:
Both the compact and the fullpresentation variants of the applet had
an instance of a timer, and both were connected to the central "running"
flag. So if both variants had been created, there were 2 timers triggering
the decreasing of the seconds, and also firing off the command once done.

Moving the countdown timer (and at the same time also a timer for
delayed saving of the state, which had the same issue) to the central root
item fixes this.
FIXED-IN: 5.12.6

Test Plan:
Applet still works as before on panel and background pane, now does proper
countdown in both cases.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13065

M  +0    -43   applets/timer/package/contents/ui/TimerView.qml
M  +41   -0    applets/timer/package/contents/ui/main.qml

https://commits.kde.org/kdeplasma-addons/6ce58880151dad9e0adb3607087de12bca65a6cc

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to