https://bugs.kde.org/show_bug.cgi?id=394396
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kri
| |ta/1d8c0c10ca99b086b77b0365
| |a471cafa391b0687
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 1d8c0c10ca99b086b77b0365a471cafa391b0687 by Dmitry Kazakov, on
behalf of Emmet O'Neill.
Committed on 18/05/2018 at 19:24.
Pushed by dkazakov into branch 'master'.
Bug fix: Ctrl-activated color picker no longer glitches out when double
clicking with a mouse.
Summary:
Currently a glitch exists where double clicking with a mouse while using the
ctrl key-activated color picker causes the `KisAbstractInputAction::eventPos`
and ``KisAbstractInputAction::eventPosF` functions to return an incorrect
value, which then causes the ctrl-picker to return an undefined and unwanted
color (usually black or white).
This patch fixes this bug by simply adding the `QEvent::MouseButtonDblClick`
case to both switch statements, returning the correct position info for the
abstract input events.
I believe this should close https://bugs.kde.org/show_bug.cgi?id=394396 .
Although the user reported a crash associated with this bug, I was unable to
reproduce any.
I also threw in some tiny formatting/style changes while I was in those files.
Test Plan:
Using a mouse, select the Brush Tool, hold the Ctrl Key to pop up a color
picker, and double click.
Without this patch applied the picked color will often incorrectly be pure
black or pure white, which seems to change depending on the zoom level.
After this patch, double clicking should not create any unwanted or
unpredictable behavior from the ctrl-picker.
Reviewers: #krita, rempt, dkazakov
Reviewed By: #krita, dkazakov
Subscribers: #krita
Tags: #krita
Differential Revision: https://phabricator.kde.org/D12953
M +10 -10 libs/ui/input/kis_abstract_input_action.cpp
M +0 -1 libs/ui/input/kis_alternate_invocation_action.cpp
https://commits.kde.org/krita/1d8c0c10ca99b086b77b0365a471cafa391b0687
--
You are receiving this mail because:
You are watching all bug changes.
