https://bugs.kde.org/show_bug.cgi?id=393222

Fabian Vogt <fab...@ritter-vogt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fab...@ritter-vogt.de

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
AFAICT this is not actually valid use of qPrintable.

The documentation states that it is a function which takes a const-ref to a
QString, which means the argument has to be either a QString or implicitly
convertable. This is not the case for this use.

That this worked at all is due to a violation of the documentation in Qt
itself, it's a macro and not a function.
The change which broke Kaffeine is this:

-#  define qPrintable(string) QString(string).toLocal8Bit().constData()
+#  define qPrintable(string)
QtPrivate::asString(string).toLocal8Bit().constData()

It replaces the explicit converstion to QString with an implicit converstion.
This means it's now behaving as documented.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to