https://bugs.kde.org/show_bug.cgi?id=339127
Nikita Sirgienko <warqu...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |18.04.1
Latest Commit| |https://commits.kde.org/can
| |tor/3b4363d41cbeb993c6d5975
| |d5cd5c93669fdcc66
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #1 from Nikita Sirgienko <warqu...@gmail.com> ---
Git commit 3b4363d41cbeb993c6d5975d5cd5c93669fdcc66 by Nikita Sirgienko.
Committed on 08/05/2018 at 20:29.
Pushed by sirgienko into branch 'master'.
Add GUI editor for R backend
Summary:
Before, if we have called `fix` function and our `EDITOR` was console editor,
we have had problems: editor starts as child process and we never can end it.
This commit fix it, by building cantor script editor as executable file and
setting the editor as editor for R.
FIXED-IN: 18.04.1
Test Plan:
1) Open terminal, set console editor as EDITOR (`export EDITOR=/bin/nano`, for
example) and start cantor in this terminal session.
2) Start R backend, create array (`a <- c(1,2,3)`, for example)
3) Call `fix(a)` and check, that you have the problem
4) Apply the patch
5) Do 1)-2) again and check, that you start edit `a` in kate
Reviewers: #cantor, asemke
Reviewed By: #cantor, asemke
Subscribers: #cantor, #kde_edu
Tags: #kde_edu, #cantor
Differential Revision: https://phabricator.kde.org/D12721
M +2 -1 src/CMakeLists.txt
M +3 -0 src/backends/R/rserver/rserver.cpp
M +1 -1 src/cantor_part.cpp
A +10 -0 src/scripteditor/CMakeLists.txt
A +44 -0 src/scripteditor/main.cpp [License: GPL (v2+)]
R +4 -0 src/scripteditor/scripteditorwidget.cpp [from:
src/scripteditorwidget.cpp - 098% similarity]
R +1 -0 src/scripteditor/scripteditorwidget.h [from:
src/scripteditorwidget.h - 098% similarity]
https://commits.kde.org/cantor/3b4363d41cbeb993c6d5975d5cd5c93669fdcc66
--
You are receiving this mail because:
You are watching all bug changes.
