https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #75 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 947b03d674e8f962f1a2d832524d3a8fdeda8ae1 by David Edmundson.
Committed on 04/05/2018 at 12:05.
Pushed by davidedmundson into branch 'master'.

Guard BookmarksRunner thread use

Summary:
Krunner::match is performed in potentially multiple overlapping threads
as a user presses each character. Qt SQL is not thread safe according to
the docs or according to the numerous reports.

It's a bit of a blind patch, ideally we should only use the database in
the thread that opened it.

This patch at least this means queries will be queued which I think will
be enough.

Test Plan: Restarted krunner. Still saw my firefox bookmarks

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: rempt, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12683

M  +5    -0    runners/bookmarks/fetchsqlite.cpp
M  +2    -0    runners/bookmarks/fetchsqlite.h

https://commits.kde.org/plasma-workspace/947b03d674e8f962f1a2d832524d3a8fdeda8ae1

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to