https://bugs.kde.org/show_bug.cgi?id=393170
Peter Mühlenpfordt <de...@ukn8.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |18.04.1
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/gwe
| |nview/5e7fe7535f9d5fb2de44f
| |e408fe8cf5b0f7937b1
Status|CONFIRMED |RESOLVED
--- Comment #2 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 5e7fe7535f9d5fb2de44fe408fe8cf5b0f7937b1 by Peter Mühlenpfordt.
Committed on 19/04/2018 at 09:37.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Fix duplicate and markup displaying failed-save message box
Summary:
When saving of a file fails, two dialogs are displayed. One of them
contains markup tags like `<html>` and `<tt>`.
The duplicate message box is caused by KJob's (not disabled) internal
error handling. The markup is displayed because of using strings with
markup as argument for `xi18n*` functions without special handling.
FIXED-IN: 18.04.1
Test Plan:
1. Open Gwenview in View or Browse Mode
2. {nav File > Save As} or {key Ctrl Shift S}
3. Try to save in a folder you don't have write permission (e.g. Root)
4. Error message box should display only once and without markup tags
1. Open Gwenview in View or Browse Mode
2. Edit a readonly file (e.g. rotate with {key Ctrl R})
3. Click {nav Save} or {nav Save All}
4. Error message box should display only once and without markup tags
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D12302
M +1 -1 app/gvcore.cpp
M +1 -1 app/saveallhelper.cpp
M +5 -2 lib/document/savejob.cpp
https://commits.kde.org/gwenview/5e7fe7535f9d5fb2de44fe408fe8cf5b0f7937b1
--
You are receiving this mail because:
You are watching all bug changes.
