https://bugs.kde.org/show_bug.cgi?id=386111

--- Comment #4 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 804d0bd42a23488a6bbd8090ee2590871ddeb64e by David Edmundson.
Committed on 09/04/2018 at 21:58.
Pushed by davidedmundson into branch 'Applications/18.04'.

Fix rubber band selection drawing contents misaligned with scaling

Summary:
in drawPixmap(source, sourceRect) the source rect is in native pixels.

In this code the size was scaled by the DPR, but the location was not.
blendRect is the contents of a selection rectangle, offset from the
bounding darker blue rectangle. Hence we haven't really noticed.

This completely fixes the rectangle when the scale == 2.0/3.0

Some smaller artifacts remain on fractional scale factors, which is a
separate code bug with the same symptoms.

Reviewers: aacid, rkflx

Reviewed By: rkflx

Subscribers: sander, rkflx, anthonyfieroni, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D8980

M  +3    -2    ui/pageview.cpp

https://commits.kde.org/okular/804d0bd42a23488a6bbd8090ee2590871ddeb64e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to