https://bugs.kde.org/show_bug.cgi?id=392654
Michael Pyne <mp...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
Version Fixed In| |18.04
Latest Commit| |https://commits.kde.org/kde
| |src-build/9d09e4787898061ae
| |38bc83dd53ca2f7ca88dca1
--- Comment #2 from Michael Pyne <mp...@kde.org> ---
Git commit 9d09e4787898061ae38bc83dd53ca2f7ca88dca1 by Michael Pyne.
Committed on 04/04/2018 at 03:41.
Pushed by mpyne into branch 'master'.
git: Ensure we skip modules that we say we must skip.
The git code recognizes when a module that is selected for update/build
implicitly (e.g. because it is included as a subset of a module grouping
that *was* asked for) does not actually have a git branch. This often
happens for newly-introduced modules (which obviously won't already have
historical "stable" branches).
Rather than forcing users to know that a module is new and manually
ignore it we announce we will skip the build for these modules.
However I confused the return code in this function; no errors are
returned, only exceptions are used for errors, which meant kdesrc-build
would try to merrily build the non-existant module anyways.
Fixed by making this an error. I looked at making it possible to
completely elide the module from the update/build list entirely but that
requires a network call (we can't rely on cached source code since
we can't download non-existent sources), and I don't think that's
a good idea. The error message can probably be worded better though.
FIXED-IN:18.04
M +5 -6 modules/ksb/Updater/Git.pm
https://commits.kde.org/kdesrc-build/9d09e4787898061ae38bc83dd53ca2f7ca88dca1
--
You are receiving this mail because:
You are watching all bug changes.
