https://bugs.kde.org/show_bug.cgi?id=383850
--- Comment #6 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 79a537ee840c629ed59ae8542f1041991910c1a2 by Henrik Fehlauer.
Committed on 21/03/2018 at 01:02.
Pushed by rkflx into branch 'Applications/18.04'.
Prevent duplicate slashes in Recent Folders
Summary:
Sometimes the {nav Recent Folders} tab on the {nav Start Page} would
show directory entries with multiple `/` at the end. Clicking on those
folders works fine, but as the same folder could also be added without
two slashes, in some cases there were multiple entries for the same
location.
The duplicate slash is caused by a porting mistake in d760ced7cb5b,
which added `/` unconditionally while `KUrl::AddTrailingSlash` only
added `/` if there was none at the end. Performing this check manually
fixes the bug.
Note that the fix for Bug #312060 (differentiate between home and root
folder for remote hosts) and what was added in 7eb5472f6539 (no password
dialog right after startup) are still in effect as well, even after
porting away from `KUrl`.
As a side effect, visiting `/` does not result anymore in broken
{nav Recent Folder} entries (non-functional and showing an error icon).
KIO warnings are gone, too:
kf5.kio.core: Invalid URL: QUrl("")
Test Plan:
Open folder, {nav Go > Up}, switch to {nav Start Page} and notice how
now the added recent folder only has a single slash at the end. In
particular, there is only a single entry for this location after
navigating back and forth again.
Start `sshd`, `sftp://localhost` still shows home folder,
`sftp://localhost/` shows root dir. Killing `kiod` and restarting
Gwenview does not show a password prompt on the {nav Start Page}.
Visit `/`, switch back to {nav Start Page} and observe that the newly
added entry shows and works correctly.
Reviewers: #gwenview, muhlenpfordt
Reviewed By: #gwenview, muhlenpfordt
Subscribers: muhlenpfordt
Differential Revision: https://phabricator.kde.org/D11492
M +5 -2 app/gvcore.cpp
https://commits.kde.org/gwenview/79a537ee840c629ed59ae8542f1041991910c1a2
--
You are receiving this mail because:
You are watching all bug changes.
