https://bugs.kde.org/show_bug.cgi?id=391758

--- Comment #5 from Henrik Fehlauer <rk...@lab12.net> ---
Nice, thanks for the patch. Your first contribution was ten years ago, wow!

I tested your patch, it works fine and looks good to me. You even changed the
tabstops.

However, other members of Gwenview should also get a chance to comment, for
which we use Phabricator nowadays. Would you be able to resubmit your patch
there? (Sorry for not mentioning this earlier.) See
https://community.kde.org/Infrastructure/Phabricator#Basic_Tasks.

> I just realized that I introduced some &amp in the ui file (don't know why).
That's a known problem (in your case affecting Qt Designer), see
https://github.com/GoldenCheetah/GoldenCheetah/wiki/Working-around-KDE-shortcut-injection.

> Concerning your question, I use position (and size)
> when I have to crop multiple similar images.
Okay, then we shouldn't remove it probably.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to