https://bugs.kde.org/show_bug.cgi?id=378463

Roman Inflianskas <infr...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/spe
                   |                            |ctacle/d47ab66eb9a2a0ce7a62
                   |                            |dabbc3bf632898186b8e
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |18.04.0
         Resolution|---                         |FIXED

--- Comment #4 from Roman Inflianskas <infr...@gmail.com> ---
Git commit d47ab66eb9a2a0ce7a62dabbc3bf632898186b8e by Roman Inflianskas.
Committed on 06/03/2018 at 16:43.
Pushed by romaninflianskas into branch 'master'.

Add optional window title to filename templates

Summary:
Add '%T' placeholder for filename pattern to insert window title.

Example filenames for pattern `%Y-%M-%D %H-%m-%S. %T`:
2018-02-21 19-11-55. romas : byobu.png
2018-02-21 19-12-20.png

Example filenames for pattern `%T`:
romas : byobu.png
Screenshot.png

Closes T8036
FIXED-IN: 18.04.0

Test Plan:
Steps:
# Go to `Configure... -> Save`.
# Enter to `Default Save Filename -> Filename` tempate `%Y-%M-%D %H-%m-%S. %T`.
# Press `OK`.
# Save screenshot.
# Observe that screenshot filename matches pattern.

Examples of filenames with empty window title:
> | Input | Result |
> | --- | --- |
> | Screenshot_%T_ProjectX | Screenshot_ProjectX |
> | %T_ProjectX | ProjectX |
> | Screenshot_%T | Screenshot |
> | %T | Screenshot |

Reviewers: rkflx, #spectacle

Reviewed By: rkflx, #spectacle

Subscribers: ngraham, rkflx

Tags: #spectacle

Maniphest Tasks: T8036

Differential Revision: https://phabricator.kde.org/D10709

M  +1    -0    doc/index.docbook
M  +68   -13   src/ExportManager.cpp
M  +11   -0    src/ExportManager.h
M  +3    -1    src/Gui/SettingsDialog/SaveOptionsPage.cpp
M  +1    -0    src/PlatformBackends/ImageGrabber.h
M  +16   -2    src/PlatformBackends/X11ImageGrabber.cpp
M  +1    -0    src/PlatformBackends/X11ImageGrabber.h
M  +4    -2    src/SpectacleCore.cpp

https://commits.kde.org/spectacle/d47ab66eb9a2a0ce7a62dabbc3bf632898186b8e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to