https://bugs.kde.org/show_bug.cgi?id=390953
Martin Flöser <mgraess...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.12.3
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kwi
| |n/e1afef3d4563803249dc25487
| |bc086f753c4e0ea
Status|UNCONFIRMED |RESOLVED
--- Comment #19 from Martin Flöser <mgraess...@kde.org> ---
Git commit e1afef3d4563803249dc25487bc086f753c4e0ea by Martin Flöser.
Committed on 05/03/2018 at 18:31.
Pushed by graesslin into branch 'Plasma/5.12'.
Sanity check WindowQuad before trying to create a grid out of it
Summary:
When one uses:
* breeze as of 5.12
* wobbly windows
* shaded window
* a distribution building with assert enabled
and starts to move a shaded window, KWin asserts. The root cause for
this is that WindowQuad::makeSubQuad has an assert for y1 being smaller
than y2. With the combination listed above this is not guaranteed. For
the left shadow quad the y1 and y2 are identical and thus trying to
split it, results in the assert condition.
The problem of the shadow quad having an invalid size might be addressed
as well with D10811. Due to that the generation of the quads is not
touched. Instead a sanity check is introduced to not try to split
already invalid sized quads.
FIXED-IN: 5.12.3
Test Plan: Added unit test hit the assert, now doesn't hit it any more
Reviewers: #kwin, #plasma
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D11015
M +1 -0 autotests/integration/effects/CMakeLists.txt
A +197 -0 autotests/integration/effects/wobbly_shade_test.cpp
[License: GPL (v2)]
M +12 -0 libkwineffects/kwineffects.cpp
https://commits.kde.org/kwin/e1afef3d4563803249dc25487bc086f753c4e0ea
--
You are receiving this mail because:
You are watching all bug changes.
