https://bugs.kde.org/show_bug.cgi?id=389413

Nikita Melnichenko <nikita+...@melnichenko.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kru
                   |                            |sader/dd7d756f65137ccaf0df7
                   |                            |b126fd375201f86c061
         Resolution|---                         |FIXED

--- Comment #16 from Nikita Melnichenko <nikita+...@melnichenko.name> ---
Git commit dd7d756f65137ccaf0df7b126fd375201f86c061 by Nikita Melnichenko.
Committed on 02/03/2018 at 07:04.
Pushed by melnichenko into branch 'master'.

Fixed a crash when browsing dirs with malformed symlinks

Two major changes for improved stability:
* check the status of lstat and show a "broken" file entry
* use new readLinkSafely function which does not consider stat_p.st_size
but gradually increases buffer until the link destination path fits into
the buffer - this helps in case st_size contains garbage
(some network fs don't care about setting the right size)

As a complementary bonus, the change fixes the following warning:
filesystem.cpp:239:35: warning: variable length array ‘buffer’ is used

FIXED: [ 389413 ] Krusader crashes when entering directories with read errors
Related: bug 390994

Differential Revision: https://phabricator.kde.org/D10761

M  +8    -0    krusader/FileSystem/fileitem.cpp
M  +3    -1    krusader/FileSystem/fileitem.h
M  +58   -23   krusader/FileSystem/filesystem.cpp
M  +4    -1    krusader/FileSystem/filesystem.h

https://commits.kde.org/krusader/dd7d756f65137ccaf0df7b126fd375201f86c061

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to