https://bugs.kde.org/show_bug.cgi?id=389991

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.12.2
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/pow
                   |                            |erdevil/4ae36ddddaee91a23dc
                   |                            |b0736418295269da14152
         Resolution|---                         |FIXED

--- Comment #46 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 4ae36ddddaee91a23dcb0736418295269da14152 by David Edmundson.
Committed on 20/02/2018 at 12:26.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Fix PowerDevil shortcuts migration

Summary:
5.11 -> 5.12 migrated shortcuts from kded5 to the correct component name
org_kde_powerdevil for good reasons
However, despite a kconfupdate script working correctly and moving the
old keys, kglobalaccel is running whilst we update and it syncs the old
values later. On future loads it detects the duplication and removes the
powerdevil entries.

This patch removes the old powermanagent entries in the kded5 component
at powerdevil startup which is at runtime where we can talk to
kglobalaccel, but before powerdevil has registered the new actions.

This should handle both users that haven't upgraded to 5.12 yet, as well
as users who hit the previous config script.

Ideally kconf_update needs to be patched to do migration at appropriate
times.
FIXED-IN: 5.12.2

Test Plan:
"broke" my config by putting in values in the old place with a custom shortcut
for poweroff
Restarted kglobalaccel
Ran powerdevil
Shortucts worked
Cleanly quit kglobalaccel
Config stayed synced

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, fvogt, aacid, cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10668

M  +0    -2    CMakeLists.txt
M  +55   -0    daemon/powerdevilapp.cpp
M  +1    -0    daemon/powerdevilapp.h
D  +0    -1    kconf_update/CMakeLists.txt
D  +0    -12   kconf_update/powerdevil_move_shortcuts.upd

https://commits.kde.org/powerdevil/4ae36ddddaee91a23dcb0736418295269da14152

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to