https://bugs.kde.org/show_bug.cgi?id=390032
Nate Graham <pointedst...@zoho.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kir
| |igami/cf677c81c7ff5e3db424b
| |6b6784f1050dea99d7f
Status|CONFIRMED |RESOLVED
--- Comment #2 from Nate Graham <pointedst...@zoho.com> ---
Git commit cf677c81c7ff5e3db424b6b6784f1050dea99d7f by Nathaniel Graham.
Committed on 14/02/2018 at 16:45.
Pushed by ngraham into branch 'master'.
Eliminate unnecessary bottom padding on OverlaySheets
Summary:
The OverlaySheet already incorporates topMargin and bottomMargin into its
height calculation, so we don't need to add any extra padding.
Test Plan:
Tested with Discover's review input sheet.
Before:
{F5710938}
After:
{F5710940}
Also tested in Kirigami Gallery; all pop-ups I could find still looked good.
Reviewers: #kirigami, apol, mart
Reviewed By: #kirigami, mart
Subscribers: plasma-devel
Tags: #kirigami
Differential Revision: https://phabricator.kde.org/D10502
M +1 -1 src/controls/templates/OverlaySheet.qml
https://commits.kde.org/kirigami/cf677c81c7ff5e3db424b6b6784f1050dea99d7f
--
You are receiving this mail because:
You are watching all bug changes.
