https://bugs.kde.org/show_bug.cgi?id=306835

Peter Mühlenpfordt <de...@ukn8.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/gwe |https://commits.kde.org/gwe
                   |nview/b55420b2ac3dc72ebffdb |nview/8a6a4ea6b9853ef4c9a91
                   |89dbb9e662d64950ecd         |6d2d91d8a7a02ad6b64
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 8a6a4ea6b9853ef4c9a916d2d91d8a7a02ad6b64 by Peter Mühlenpfordt.
Committed on 26/01/2018 at 07:35.
Pushed by muhlenpfordt into branch 'master'.

Fix issues with clicking directories in tree view

Summary:
Selecting another directory in tree while showing an image in view mode,
opens the first image from the selected directory in view mode. If the
folder contains subfolders, gwenview selects the first one and switches
to browse mode.
This patch changes selection of first **item** back to first **image**
(introduced in D8934) to fix this and toggles between browse/view mode
only after clicking the already selected directory in tree.
Additionally a trailing slash is stripped from the current dir url in
context manager to fix a failing compare to initially stored dir url.

Test Plan:
1. Open image in view mode
2. Click on another directory in tree view
-> Should view the first image in new directory

1. Open image in view mode
2. Click multiple times on the same directory in tree view
-> Should toggle browse/view mode

Reviewers: rkflx

Reviewed By: rkflx

Subscribers: ngraham, rkflx

Differential Revision: https://phabricator.kde.org/D9886

M  +28   -5    app/mainwindow.cpp
M  +2    -0    app/mainwindow.h
M  +2    -1    doc/index.docbook
M  +2    -1    lib/contextmanager.cpp

https://commits.kde.org/gwenview/8a6a4ea6b9853ef4c9a916d2d91d8a7a02ad6b64

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to