https://bugs.kde.org/show_bug.cgi?id=387507
wolthera <griffinval...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
CC| |griffinval...@gmail.com
--- Comment #1 from wolthera <griffinval...@gmail.com> ---
Confirmed. It seems that "computeRotationLikeValue" doesn't take into account
thestrength slider, and I can't quite figure out if the only other place this
function is used(KisPressureRotationOption) also should take into account
strength or not.
Anyway, I am neck deep in refactorings elsewhere, so I'll post my diff that
fixes the issue here:
diff --git a/plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
b/plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
index cf6f630..a0c8217 100644
--- a/plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
+++ b/plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
@@ -132,8 +132,9 @@ void KisPressureHSVOption::apply(KoColorTransformation*
transfo, const KisPaintI
d->paramId = transfo->parameterId(d->parameterName);
}
- qreal value = computeRotationLikeValue(info, 0, false);
- transfo->setParameter(d->paramId, value);
+ qreal v = computeRotationLikeValue(info, 0, false);
+ v = (v) * (this->value());//multiply by strength slider.
+ transfo->setParameter(d->paramId, v);
transfo->setParameter(3, 0); //sets the type to HSV.
transfo->setParameter(4, false); //sets the colorize to false.
}
--
You are receiving this mail because:
You are watching all bug changes.
