https://bugs.kde.org/show_bug.cgi?id=350574

--- Comment #15 from Richard Mortimer <richm+...@oldelvet.org.uk> ---
(In reply to Maik Qualmann from comment #14)
> Git commit 9a17c743ea9a41c1ef050b08517343813ef6a9f4 by Maik Qualmann.
> Committed on 25/11/2017 at 22:02.
> Pushed by mqualmann into branch 'master'.
> 
> update DB to v9 and fix migration from SQLite to MySQL
> Related: bug 378838, bug 369083, bug 325654
> FIXED-IN: 5.8.0
> 
> M  +5    -1    NEWS
> M  +129  -97   data/database/dbconfig.xml.cmake.in
> M  +1    -1    data/database/mysql-global.conf
> M  +1    -20   libs/database/coredb/coredbcopymanager.cpp
> M  +5    -2    libs/database/coredb/coredbschemaupdater.cpp
> 
> https://commits.kde.org/digikam/9a17c743ea9a41c1ef050b08517343813ef6a9f4

Is there a reason why the committed patch removes all of the careful filtering
of orphan records from old broken databases that were being migrated from
pre-referential integrity schema?

There was lots of careful filtering via LEFT JOIN and IS NOT NULL to ensure
that everything that was migrated was connected to an active ALBUM root.

I was actually thinking that the same needed doing when using a SQLite database
as source and haven't seen anything to suggest that it was a bad idea. Indeed
it fixed a lot of migration complaints.

I'm also wondering why the migration has been changed to only migrate "Locale"
from the settings? There is no reference to a bug/reason for that. I cannot
tell if that slipped in by mistake or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to