https://bugs.kde.org/show_bug.cgi?id=386043
Martin Flöser <mgraess...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.11.4
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kwi
| |n/1ae7990a959ce2c3fad0a6aef
| |684cf058b07cf1e
--- Comment #10 from Martin Flöser <mgraess...@kde.org> ---
Git commit 1ae7990a959ce2c3fad0a6aef684cf058b07cf1e by Martin Flöser.
Committed on 16/11/2017 at 19:33.
Pushed by graesslin into branch 'Plasma/5.11'.
Allow a cross-process check for same applications
Summary:
Commit 5d9027b110 introduced a regression in TabBox by using the generic
framework inside KWin to test for same application. What I did not
consider was that the code in TabBox was "broken by design". It didn't
use the generic check as that is too strict and considers windows from
different processes as not belonging to the same application. But this
is not wanted in the case of TabBox.
On the other hand the change itself is an improvement to also support
Wayland in a better way and not have special handling situations. Thus
just reverting would not help.
Instead this change addresses the problem by extending the internal API
and to allow more adjustements. So far there was already an
"active_hack" boolean flag. This is extended to proper flags with an
additional flag to allow cross application checks.
The checks in Client which would filter out different applications check
for this flag and are skipped if set. In addition ShellClient also adds
support for this flag and compares for the desktop file name.
Thus we get in TabBox the same behavior as before with the advantage of
having a better shared code base working on both X11 and Wayland.
FIXED-IN: 5.11.4
Test Plan:
Started two kwrite processes on X11, clicked new in one of them,
used Alt+` and verified that there are three windows shown.
Reviewers: #kwin, #plasma
Subscribers: plasma-devel, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D8661
M +2 -2 abstract_client.cpp
M +8 -4 abstract_client.h
M +4 -4 activation.cpp
M +2 -2 client.cpp
M +2 -2 client.h
M +6 -4 group.cpp
M +7 -3 shell_client.cpp
M +1 -1 shell_client.h
M +2 -2 tabbox/tabbox.cpp
https://commits.kde.org/kwin/1ae7990a959ce2c3fad0a6aef684cf058b07cf1e
--
You are receiving this mail because:
You are watching all bug changes.
