https://bugs.kde.org/show_bug.cgi?id=386458
Bug ID: 386458
Summary: libtaskmanager test-suite depends on external
resources – dolphin, konversation
Product: plasmashell
Version: 5.11.2
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: major
Priority: NOR
Component: Task Manager
Assignee: h...@kde.org
Reporter: h.goe...@crazy-compilers.com
CC: plasma-b...@kde.org
Target Milestone: 1.0
The test-suite for libtaskmanager fails if dolphin and konversations are not
installed (see below).
The reason is that launchertasksmodeltest is not self-contained, but tries to
explicitly access
file:///usr/share/applications/org.kde.dolphin.desktop and
file:///usr/share/applications/org.kde.konversation.desktop
$./libtaskmanager/autotests/launchertasksmodeltest
********* Start testing of LauncherTasksModelTest *********
Config: Using QtTest library 5.9.2, Qt 5.9.2 (x86_64-little_endian-lp64 shared
(dynamic) release build; by GCC 5.4.0)
PASS : LauncherTasksModelTest::initTestCase()
FAIL! : LauncherTasksModelTest::shouldRoundTripLauncherUrlList() Compared
values are not the same
Actual (m.data(m.index(0, 0),
AbstractTasksModel::LauncherUrl).toString()):
"file:///usr/share/applications/org.kde.dolphin.desktop"
Expected (m_mangledUrlStrings.at(0))
: "applications:org.kde.dolphin.desktop"
Loc:
[/tmp/guix-build-plasma-workspace-5.11.2.drv-0/plasma-workspace-5.11.2/libtaskmanager/autotests/launchertasksmodeltest.cpp(70)]
PASS : LauncherTasksModelTest::shouldIgnoreInvalidUrls()
PASS : LauncherTasksModelTest::shouldRejectDuplicates()
PASS : LauncherTasksModelTest::shouldAddRemoveLauncher()
PASS : LauncherTasksModelTest::shouldReturnValidLauncherPositions()
PASS : LauncherTasksModelTest::shouldReturnValidData()
PASS : LauncherTasksModelTest::cleanupTestCase()
Totals: 7 passed, 1 failed, 0 skipped, 0 blacklisted, 48ms
********* Finished testing of LauncherTasksModelTest *********
How to reproduce
======================
Uninstall dolphin and konversations and run the test-quite.
What I'd expect
=====================
1) The test-suite should be self-contined.
2) Esp. it should not depend on such big and high-level applications like
doplhin and konversations.
Proposed solution
=====================
Copy (stripped) versions of org.kde.dolphin.desktop and
org.kde.konversation.desktop into the
test-suite and use it from here.
--
You are receiving this mail because:
You are watching all bug changes.
