https://bugs.kde.org/show_bug.cgi?id=385035
Henrik Fehlauer <rk...@lab12.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/gwe
| |nview/7389aa55dbdf9c8af9510
| |6498aa6ce082cc03eb2
--- Comment #3 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 7389aa55dbdf9c8af95106498aa6ce082cc03eb2 by Henrik Fehlauer.
Committed on 15/10/2017 at 19:33.
Pushed by rkflx into branch 'Applications/17.08'.
Fix padding of "Fit Width" button
Summary:
3e10699ac37c4 introduced "Fit to Width", but failed to adapt the width
calculation of the zoom mode buttons in the bottom zoom widget bar
accordingly. This resulted in the middle button getting its text cut off
for some languages, looking like this:
{F5431466}
There are several options to remedy this:
- Give equal width to all buttons
- Give equal width to the outer buttons (i.e. symmetric, probably the initial
intention when there were only two buttons)
- Just respect the size hint of each button individually
| {F5431473} | {F5431474} | {F5431476} |
As the three buttons are already quite wide, in order not to impact the
minimal window size too much (rules out "equal width") and at the same
time not to make the "Fit" button for English too narrow (rules out
"individual width") we choose the "symmetric" option.
Test Plan:
Switch application language to Czech, view image. Text in "Fit to Width"
(i.e. middle) button not cut off anymore, minimal window size only
slightly impacted. For English, the "Fit" button is still wide enough.
Reviewers: #kde_applications, broulik
Reviewed By: broulik
Subscribers: broulik
Differential Revision: https://phabricator.kde.org/D8306
M +0 -1 lib/zoomwidget.cpp
https://commits.kde.org/gwenview/7389aa55dbdf9c8af95106498aa6ce082cc03eb2
--
You are receiving this mail because:
You are watching all bug changes.
