https://bugs.kde.org/show_bug.cgi?id=384037
Michael Pyne <mp...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit| |https://commits.kde.org/kco | |readdons/4bdc7bb199ecd5120a | |665600394ac6d69ee1e830 Version Fixed In| |5.39 --- Comment #8 from Michael Pyne <mp...@kde.org> --- Git commit 4bdc7bb199ecd5120a665600394ac6d69ee1e830 by Michael Pyne. Committed on 05/10/2017 at 00:53. Pushed by mpyne into branch 'master'. desktoptojson: Improve legacy service type detection heuristic. This commit adds a second-pass heuristic converting requests for named service types into possible file names for corresponding Desktop Entry files as used in previous KDE releases. The current heuristic converts '/' in the requested service type name to '-'. If that fails to find a file, we now also convert '/' to '' (i.e. nothing) and try again before returning an error. This fix introduces an autotest regression if you have KDevelop installed, since the updated code now finds the *real* KDevelop/Plugin service type desktop entry in a test where it was expecting not to, the "kdevcppnolanguagesupport no servicetype" test. To avoid installed software affecting the tests I rename the service type and verify that the "no servicetype" and "with [fake] servicetype" tests continue to pass. FIXED-IN:5.39 Differential Revision: https://phabricator.kde.org/D8002 M +1 -1 autotests/data/servicetypes/fake-kdevelopplugin.desktop M +3 -3 autotests/desktoptojsontest.cpp M +23 -6 src/lib/plugin/desktopfileparser.cpp https://commits.kde.org/kcoreaddons/4bdc7bb199ecd5120a665600394ac6d69ee1e830 -- You are receiving this mail because: You are watching all bug changes.