https://bugs.kde.org/show_bug.cgi?id=383875
Friedrich W. H. Kossebau <kosse...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.2.0
Latest Commit| |https://commits.kde.org/kde
| |velop/781bb47c95fabd7e28eb2
| |c6966deb8daeb557fb5
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Friedrich W. H. Kossebau <kosse...@kde.org> ---
Git commit 781bb47c95fabd7e28eb2c6966deb8daeb557fb5 by Friedrich W. H.
Kossebau.
Committed on 04/10/2017 at 17:33.
Pushed by kossebau into branch '5.2'.
Always create Documentation tool view, fix it to work with no providers
Summary:
Creating the Documentation tool view at DocumentationController
initialization time only if the list returned by documentationProviders() is
non-empty has some flaws:
1) The QtHelp plugin delays initialization to after reaching the event loop.
So if it is the only documentation provider (provider) plugin activated, it
will return 0 providers in the beginning.
2) It ignores the option that users can enable another documentation provider
plugin
at runtime.
3) There is also no code for removing the tool view in case the user
disables any documentation providers at runtime.
4) It ignores the option of plugins like the QtHelp one allowing the user to
disable any documentation providers at runtime.
This patch always creates the toolview instead of magically creating/removing
it
automatically based on documentation provider availability and leaves it to
the user to add or remove it as they prefer.
It also prepares the Documentation tool view to properly handle the case of
no documentation providers available (done in a way to keep the current public
API).
FIXED-IN: 5.2.0
Reviewers: #kdevelop, apol
Reviewed By: #kdevelop, apol
Subscribers: kdevelop-devel
Differential Revision: https://phabricator.kde.org/D8140
M +30 -9 kdevplatform/documentation/documentationview.cpp
M +1 -1 kdevplatform/shell/documentationcontroller.cpp
https://commits.kde.org/kdevelop/781bb47c95fabd7e28eb2c6966deb8daeb557fb5
--
You are receiving this mail because:
You are watching all bug changes.
