https://bugs.kde.org/show_bug.cgi?id=385207

--- Comment #2 from Julian Seward <jsew...@acm.org> ---
+#define V128_FRACTION_MASK 0x0000FFFFFFFFFFFFULL  /* upper 64-bit fractional
mask */
+
+ULong generate_C_FPCC_helper( ULong size, ULong src_hi, ULong src ) {
+   UInt NaN, inf, zero, norm, dnorm, pos;
+   UInt bit0, bit1, bit2, bit3;

* nit: { on its own line, in the house style

* Please rename 'size' here to 'irType', because that's what it really is



+   if ( size == Ity_I16 ) {
+      frac_part = I16_FRACTION_MASK & src;
+      exp_mask = I16_EXP_MASK;
...
+     exp_mask = V128_EXP_MASK;
+     exp_part = exp_mask & src_hi;
+     sign_bit = src_hi >> 63;
+   }

Add

  else {
    vassert(0);
  }

so as to cause the system to fail if any other value is passed for irType.


OK to land with the above points fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to