https://bugs.kde.org/show_bug.cgi?id=383059
--- Comment #7 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit 46e95531c731bd0a3a325ad5fc178e5256d29f0c by Henrik Fehlauer.
Committed on 29/09/2017 at 18:49.
Pushed by rkflx into branch 'Applications/17.08'.
Fix icon colors of inline context buttons also in full screen mode
Summary:
In the darker full screen mode, the icons of the mouse-over overlays
were still hard to see against the similarly coloured background. This
was because when switching to full screen mode, we would miss to reset
the icon (except for `mToggleSelectionButton`). The root cause is
`QAbstractButton`, which just holds onto a pixmap and has no way of
knowing `KIconLoader` would return a differently coloured icon when the
colour palette changes (as is the case for colour-aware icon sets like
"Breeze").
To fix this, we simply use `QIcon::fromTheme` instead of `SmallIcon`,
which returns a proper `QIcon` instead of a `QPixmap` and automatically
adapts to colour palette changes.
(This is a followup patch to D7988.)
FIXED-IN: 17.08.2
Test Plan:
Overlay icons perfectly visible against the background color in standard
and full screen mode. Tested with "Breeze" and "Breeze Dark" colour
schemes as well as "Breeze", "Oxygen" and "Fusion" widget styles.
("Fusion" does not allow to customize the size for small icons, though.)
Reviewers: #kde_applications, broulik, ngraham
Reviewed By: broulik
Differential Revision: https://phabricator.kde.org/D8031
M +2 -2 lib/datewidget.cpp
M +6 -6 lib/thumbnailview/previewitemdelegate.cpp
M +2 -2 lib/thumbnailview/thumbnailbarview.cpp
https://commits.kde.org/gwenview/46e95531c731bd0a3a325ad5fc178e5256d29f0c
--
You are receiving this mail because:
You are watching all bug changes.
