https://bugs.kde.org/show_bug.cgi?id=373481
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
|ta/317438eb2460ec0da2a30981 |ta/ff43d055f07e84331e4f3f1f
|1c0b3009553aa957 |0a5d21feac49d022
Status|REOPENED |RESOLVED
--- Comment #5 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit ff43d055f07e84331e4f3f1f0a5d21feac49d022 by Dmitry Kazakov.
Committed on 16/08/2017 at 09:45.
Pushed by dkazakov into branch 'kazakov/async-animation-rendering'.
Fix a set of OCIO-related bugs
1) Don't reset LUT docker when moving the window over screens. We should
actually check if the combo boxes contents is going to change or not in
resetOcioConfiguration() and keep them intact if possible for not
resetting the user's settings.
2) The display shader should be recompiled not when setDisplayFilter() is
called, but when filter->updateShader() is called. The point is that
quite a lot of filter updates happen without(!) recompiling the shader.
And, obviously, the order of calls to updateShader() and
setDisplayFilter() is generally undefined, so if we try to recompile it
in setDisplayFilter() there might be still outdated version of it.
3) Removed explicit initialization of the display filter in
LutDockerDock::setCanvas(). The point is that the correct filter will
be correctly initialized later in updateDisplaySettings(). And this
extra call made Krita recompute the image 6(!) times when loading any
image. That can take ages on complex images like miloor_turntable_002.kra
M +4 -1 libs/ui/canvas/kis_display_filter.h
M +38 -25 libs/ui/opengl/kis_opengl_canvas2.cpp
M +3 -1 libs/ui/opengl/kis_opengl_canvas2.h
M +14 -0 libs/ui/widgets/squeezedcombobox.cpp
M +11 -0 libs/ui/widgets/squeezedcombobox.h
M +42 -36 plugins/dockers/lut/lutdocker_dock.cpp
M +16 -8 plugins/dockers/lut/ocio_display_filter.cpp
M +2 -2 plugins/dockers/lut/ocio_display_filter.h
https://commits.kde.org/krita/ff43d055f07e84331e4f3f1f0a5d21feac49d022
--
You are receiving this mail because:
You are watching all bug changes.
