https://bugs.kde.org/show_bug.cgi?id=278431

David Faure <fa...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kdel
                   |                            |ibs/725523993e6037b94a99348
                   |                            |fc3879a4070c3dc7d
   Version Fixed In|                            |4.14.17

--- Comment #71 from David Faure <fa...@kde.org> ---
Git commit 725523993e6037b94a99348fc3879a4070c3dc7d by David Faure.
Committed on 30/01/2016 at 10:31.
Pushed by dfaure into branch 'KDE/4.14'.

Fix KDirListerCache crash with two listers for an empty dir in the cache.

The wrong optimization if (!itemU->lstItems.isEmpty()) meant that if
the cached dir is empty, we didn't create a CachedItemsJob. If there is
also no ListJob happening, then the lister would just be forever in the
listersCurrentlyListing list, which would lead to crashes later on.

The user-visible bug was hard to trigger (needed autofs enabled, I suppose to
trigger [1], although not sure why it's related), but after enabling
DEBUG_CACHE,
simply clicking on the trash place entry in dolphin would trigger an assert.

[1] "KDirListerCache::forgetDirs: Not adding a watch on "file:///" because it
contains a manually mounted subdir"
FIXED-IN: 4.14.17

M  +9    -7    kio/kio/kdirlister.cpp
M  +31   -0    kio/tests/kdirlistertest.cpp
M  +1    -0    kio/tests/kdirlistertest.h

http://commits.kde.org/kdelibs/725523993e6037b94a99348fc3879a4070c3dc7d

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to