https://bugs.kde.org/show_bug.cgi?id=382313

Martin Flöser <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/139b4dc82a9423e42285a469a
                   |                            |b7f7cc4139d7054
             Status|REOPENED                    |RESOLVED
   Version Fixed In|                            |5.10.4
         Resolution|---                         |FIXED

--- Comment #11 from Martin Flöser <mgraess...@kde.org> ---
Git commit 139b4dc82a9423e42285a469ab7f7cc4139d7054 by Martin Flöser.
Committed on 17/07/2017 at 14:51.
Pushed by graesslin into branch 'Plasma/5.10'.

Properly swap the quick tile side when pressing the shortcut again

Summary:
The quick tile shortcuts have a feature of moving the window to the next
screen if one presses the same shortcut again.
E.g. if a window is quick tiled to the left on the right most screen,
quick tile again to left should move it to the left screen and quick tile
right. Thus it swaps the borders.

This wasn't handled correctly, especially not for modes like top and
bottom. If a window is quick tiled to the top an impossible mode was
generated: Left | Right. Doesn't make sense.

This change fixes the mode swapping and extends our quick tile testing
to cover the situation.
FIXED-IN: 5.10.4

Test Plan: Extended test case

Reviewers: #plasma, #kwin

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D6708

M  +32   -18   autotests/integration/quick_tiling_test.cpp
M  +3    -1    geometry.cpp

https://commits.kde.org/kwin/139b4dc82a9423e42285a469ab7f7cc4139d7054

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to