https://bugs.kde.org/show_bug.cgi?id=382063

Martin Flöser <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |5.10.4
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/962a2e39ee7a476e416f067dd
                   |                            |31f10e3a4a63784

--- Comment #1 from Martin Flöser <mgraess...@kde.org> ---
Git commit 962a2e39ee7a476e416f067dd31f10e3a4a63784 by Martin Flöser.
Committed on 06/07/2017 at 17:14.
Pushed by graesslin into branch 'Plasma/5.10'.

[qpa] Prevent crash due to Surface getting null

Summary:
This is a regression due to changes in Breeze to support Qt 5.8+ behavior
change. KWin's own QPA operates like < Qt 5.7 and breeze was programmed
against that. Due to that it can happen now that Breeze hits code paths
in which KWin does not have a surface.

To trigger one only needed to open the user actions menu twice.

This change adds a test case which simulates the problem and fixes all
crashes happening in the code path.

Most likely shadows are now broken for KWin's own windows, this change is
only to prevent the crash and thus is for 5.10 branch, while shadow
fixing will go to master branch.
FIXED-IN: 5.10.4

Test Plan: New test case

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D6533

M  +1    -0    autotests/integration/CMakeLists.txt
A  +114  -0    autotests/integration/dont_crash_useractions_menu.cpp    
[License: GPL (v2)]
M  +3    -0    plugins/qpa/backingstore.cpp
M  +3    -1    plugins/qpa/nativeinterface.cpp

https://commits.kde.org/kwin/962a2e39ee7a476e416f067dd31f10e3a4a63784

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to