https://bugs.kde.org/show_bug.cgi?id=381963

            Bug ID: 381963
           Summary: Kigo: wrong lower bound for handicap value
           Product: kigo
           Version: 0.5.6
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: sasc...@mailbox.org
          Reporter: martino.pi...@gmail.com
                CC: kde-games-b...@kde.org
  Target Milestone: ---

Created attachment 106433
  --> https://bugs.kde.org/attachment.cgi?id=106433&action=edit
Proposed patch

When setting up a game with no handicap and then quitting the application, the
handicap value does not go stored in the preferences as it should, since a
value lower than 2 for handicap does not pass validation (while a value of 1
should be valid, since it represents no handicap). Proposed patch on
attachment.

Steps to reproduce:

1) Start Kigo, set up a game with no handicap.
2) Quit Kigo. If Kigo was started from the command line, note the debug message
`kigo(xxxxx) Preferences::setFixedHandicapValue: setFixedHandicapValue: value 
1  is less than the minimum value of 2`
3) Start Kigo again.

Actual Results: when starting Kigo again at step 3, the handicap value in the
game setup is 2 stones.

Expected Results: the value in the game setup should be no handicap.

Observed both in the Arch Linux package (kdegames-kigo 17.04.2-1) and compiling
Kigo from sources (commit 8b65479c0efc2c4f603f4c14089a0a340f97581f).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to