https://bugs.kde.org/show_bug.cgi?id=381210

Martin Flöser <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.10.3
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/0df09a8cbbb1caa217c8deb59
                   |                            |700bd12f27e45b8

--- Comment #15 from Martin Flöser <mgraess...@kde.org> ---
Git commit 0df09a8cbbb1caa217c8deb59700bd12f27e45b8 by Martin Flöser.
Committed on 18/06/2017 at 19:04.
Pushed by graesslin into branch 'Plasma/5.10'.

Better handle cases when the xkb keymap fails to be created

Summary:
If the keymap cannot be created a few pointers in Xkb are null.
We should make sure to not call any xkbcommon functions on those
null pointers and instead use proper fallbacks.

This change introduces fixes for a few usages, but it's not unlikely
that there are more cases.
FIXED-IN: 5.10.3

Test Plan:
Autotest added for the condition of the bug, which does
not crash any more. Just starting the test found a few more crash
cases.

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D6260

M  +1    -0    autotests/integration/CMakeLists.txt
A  +102  -0    autotests/integration/keymap_creation_failure_test.cpp    
[License: GPL (v2)]
M  +7    -1    xkb.cpp

https://commits.kde.org/kwin/0df09a8cbbb1caa217c8deb59700bd12f27e45b8

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to