https://bugs.kde.org/show_bug.cgi?id=378508
Marco Martin <notm...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Latest Commit| |https://commits.kde.org/pla
| |sma-framework/6ffe068b80143
| |ba92cae6eaddf1bcd42c5ff4bed
Resolution|--- |FIXED
--- Comment #22 from Marco Martin <notm...@gmail.com> ---
Git commit 6ffe068b80143ba92cae6eaddf1bcd42c5ff4bed by Marco Martin.
Committed on 09/06/2017 at 14:16.
Pushed by mart into branch 'master'.
generate the old key before updating enabledborders
Summary:
sometimes a frame changed enabled borders causing a dangling
pointer in s_sharedFrames, since oldkey was generated
with the new enabled borders, it generated a key not present
in the hash, tryed to remove it and left the one associated
with the old key in the hash.
if the need to reuse a frame with that key ever arised again,
we had a crash
Test Plan:
couldn't reproduce the crash neither with or without patch,
with the patch, if i put debug in every place a framedata is removed,
searching if the key is in the hash before removing it, now
it's always true, before sometimes it was false
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel, #frameworks
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D6162
M +1 -2 src/plasma/framesvg.cpp
https://commits.kde.org/plasma-framework/6ffe068b80143ba92cae6eaddf1bcd42c5ff4bed
--
You are receiving this mail because:
You are watching all bug changes.
