https://bugs.kde.org/show_bug.cgi?id=380270

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |clarative/695f24fb522a5ae6f
                   |                            |e2530cbd72d3966b234b025

--- Comment #10 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 695f24fb522a5ae6fe2530cbd72d3966b234b025 by David Edmundson.
Committed on 31/05/2017 at 09:08.
Pushed by davidedmundson into branch 'master'.

Don't leak MimeData object

Summary:
A DeclarativeDropArea creates a new DeclarativeDragDropEvent on every
enter/move/leave event.

The getter method for the mimeData property creates a new MimeData
QObject wrapper, which then leaks.

Use of the mimeData object outside of the event shouldn't be expected to
work, and a quick grep couldn't find any usage.

Test Plan: Dragged some things

Reviewers: #plasma, mart, hein

Reviewed By: #plasma, mart, hein

Subscribers: hein, plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D6017

M  +2    -2    src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp
M  +2    -3    src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h

https://commits.kde.org/kdeclarative/695f24fb522a5ae6fe2530cbd72d3966b234b025

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to