https://bugs.kde.org/show_bug.cgi?id=380209
Elvis Angelaccio <elvis.angelac...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/f060ad5f1ad06
| |359088887cb2f7e691c994ccfc5
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit f060ad5f1ad06359088887cb2f7e691c994ccfc5 by Elvis Angelaccio.
Committed on 26/05/2017 at 09:25.
Pushed by elvisangelaccio into branch 'Plasma/5.8'.
Always add data sources in SystemMonitorEngine::sourceRequestEvent()
Summary:
Otherwise if we show the plasma-nm applet twice, m_sensors won't be empty
and we won't be able to fect the connection speed data.
git blame points to
https://github.com/KDE/kde-workspace/commit/ba7444f99ab08cf0a305899bf66879314bd0d5a9
and
https://github.com/KDE/kde-workspace/commit/235fea1868b560acf32c5c13a3d16ef233b50be6
but they don't really explain why setData() was called only if m_sensors
was empty.
Test Plan:
- plasmoidviewer -a org.kde.plasma.networkmanagement
- open the networkmanager applet twice
- make sure the connection's speed graph works the 2nd time.
Reviewers: #plasma, jgrulich
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5973
M +2 -12 dataengines/systemmonitor/systemmonitor.cpp
https://commits.kde.org/plasma-workspace/f060ad5f1ad06359088887cb2f7e691c994ccfc5
--
You are receiving this mail because:
You are watching all bug changes.
