https://bugs.kde.org/show_bug.cgi?id=374075
Elvis Angelaccio <elvis.angelac...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kco
| |readdons/792680d43877efbea7
| |c2367bab564e41da98be45
Version Fixed In| |5.35
Status|CONFIRMED |RESOLVED
--- Comment #5 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 792680d43877efbea7c2367bab564e41da98be45 by Elvis Angelaccio.
Committed on 21/05/2017 at 19:59.
Pushed by elvisangelaccio into branch 'master'.
Do not watch QRC's paths
Watching a QRC path is not supported and results in `"."` being
watched which can lead to problems.
For example in bug #374075 KIO adds ":/kio5/newfile-templates"
as path to watch (this is probably another bug in itself).
If we are already watching "/home/user", this breaks the emission
of the dirty() signal for every new children of "/home/user" (somehow,
the relative path is used for them, e.g. "./foo.txt" instead of
"/home/user/foo.txt"). In particular, in inotifyEventReceived()
e->m_client is empty and so e->path is not added to
e->m_pendingFileChanges. This only happens if "/home/user" is also
the cwd of the process using KDirWatch.
Ignoring QRC paths fixes this issue.
FIXED-IN: 5.35
Test Plan:
>From dolphin, Create New -> Text File in a folder which is also the current
>working
directory of the dolphin process.
Reviewers: dfaure
Differential Revision: https://phabricator.kde.org/D5877
M +24 -0 autotests/kdirwatch_unittest.cpp
M +4 -0 src/lib/io/kdirwatch.cpp
https://commits.kde.org/kcoreaddons/792680d43877efbea7c2367bab564e41da98be45
--
You are receiving this mail because:
You are watching all bug changes.
