https://bugs.kde.org/show_bug.cgi?id=375195
--- Comment #11 from RJVB <rjvber...@gmail.com> --- > helps us developers writing better code That's a bit the point, using named logical operators can easily be defended as "helping write better code". "not" is more visible than "!", and confusion/mistakes between the logical and bitwise versions become much less likely and probably easier to spot. > There's an option to make MSVC adhere more to compiler standards (/Za) but I > do not know the side effects of it. That too is one of the points: there appear to be side-effects. If that is not the case, then the ECM should add that option when MSVC is used instead of using -fno-operator-names everywhere else. Actually, q quick read of the /Za description suggests that might be a good idea anyway: https://msdn.microsoft.com/en-us/library/aa278577(v=vs.60).aspx Sadly I cannot test it. > The two or three individual problems with this patch have been sorted out, > and since then no developer complained. We're really better off spending our > time elsewhere. No wonder no developer has complained about a fix that was made for them. Look, this doesn't have to be a drawn-out discussion. I've brought it up because I saw you have been hesitating yourself. Let me just say 1 more thing: KDE_ENABLE_EXCEPTIONS and I'll work on an equivalent and put it up for review after testing it (hopefully with MSVC too). -- You are receiving this mail because: You are watching all bug changes.
