[kdev-python] [Bug 378827] Kevelop 4.7, 5.0.x, and 5.1.0 crashes when background parsing is turned on for Unreal Engine 4

[Francis Herne]

https://bugs.kde.org/show_bug.cgi?id=378827

--- Comment #10 from Francis Herne <m...@flherne.uk> ---
Correction, it's related to the use of MacOS Classic (why?!) line endings -
i.e. just a carriage return but no newline.

Many places in kdev-python assume that lines can be split with \n, so we should
probably normalise these earlier.

Alternative patch that solves this particular case:


diff --git a/parser/astbuilder.cpp b/parser/astbuilder.cpp
index 0e19f367..15df40a9 100644
--- a/parser/astbuilder.cpp
+++ b/parser/astbuilder.cpp
@@ -98,7 +98,8 @@ private:
 class RangeFixVisitor : public AstDefaultVisitor {
 public:
     RangeFixVisitor(const QString& contents)
-        : lines(contents.split('\n')) { };
+        // Split on all three variants - \r, \n or \r\n
+        : lines(contents.split(QRegExp("\\r\\n?|\\n"))) { };

     void visitNode(Ast* node) override {
         AstDefaultVisitor::visitNode(node);

-- 
You are receiving this mail because:
You are watching all bug changes.