https://bugs.kde.org/show_bug.cgi?id=379161
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/rel
| |easeme/309af97921a89423941b
| |5d6a5cefaed4e534c1cb
Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Harald Sitter <sit...@kde.org> ---
Git commit 309af97921a89423941b5d6a5cefaed4e534c1cb by Harald Sitter.
Committed on 25/04/2017 at 12:42.
Pushed by sitter into branch 'master'.
reduce drop limit after removing a leading kde/ part
The general assumption is that path.split.pop.join('-') will be the
i18n_path. e.g. playground/utils becomes playground-utils and
playground/utils/libs becomes also playground-utils. To that end we drop
parts until we have <= 2 to join. This was going wrong with nested projects
inside kde/* projects as we drop the first kde/ part.
So kde/kdegraphics/libs would be [kde,kdegraphics,libs] then we drop the
kde to get [kdegraphics,libs] and now no longer drop parts treating it
like playground, when really it shouldn't be as effectively our
requirements are different. Technically we want [kde,kdegraphics,libs] to
be popped until only 2 are left, we can't do that because dropping kde
is sort of a pre condition, otherwise we'll have to do some mind bending
to prevent empty paths etc.
M +49 -14 lib/releaseme/project.rb
M +48 -0 test/data/kde_projects.xml
M +11 -1 test/test_project.rb
https://commits.kde.org/releaseme/309af97921a89423941b5d6a5cefaed4e534c1cb
--
You are receiving this mail because:
You are watching all bug changes.
