https://bugs.kde.org/show_bug.cgi?id=379177

            Bug ID: 379177
           Summary: History (recentfolders) not working / folder never
                    created
           Product: gwenview
           Version: Git (add output of "git log -1 --oneline" to
                    description)
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: gwenview-bugs-n...@kde.org
          Reporter: leszek.les...@web.de
                CC: myr...@kde.org
  Target Milestone: ---

Created attachment 105177
  --> https://bugs.kde.org/attachment.cgi?id=105177&action=edit
Fix proposal

2f1ad4c GIT_SILENT made messages (after extraction)

Folder History is not working anymore. 

Commit 840d1c40bc906b0961418c8b738aef3971e7dce2 broke it. 

> QStandardPaths::locate(QStandardPaths::AppLocalDataLocation, "recentfolders/")

always returns an empty string "" when either the recentfolders folder or the
~/.local/share/gwenview folder don't exist. 
See: http://doc.qt.io/qt-5/qstandardpaths.html#locate
> If no such file or directory can be found, an empty string is returned

KStandardDirs::locateLocal behaves differently (from the api doc)
> No check is made if the specified filename actually exists. Missing 
> directories are created.

As we don't want to switch back to KStandardDirs I came up with a working patch
using QStandardPaths::writableLocation (see attachment) as 
> Note: The storage location returned can be a directory that does not exist; 
> i.e., it may need to be created by the system or the user.
(from : http://doc.qt.io/qt-5/qstandardpaths.html#writableLocation )

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to