https://bugs.kde.org/show_bug.cgi?id=378276

Elvis Angelaccio <elvis.angelac...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.34
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |dgetsaddons/8a1c758516fd606
                   |                            |bce23dd92934d899f119ac49f
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #10 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 6976a54f235544575994b77ab86a561d537187e7 by Elvis Angelaccio.
Committed on 21/04/2017 at 12:49.
Pushed by elvisangelaccio into branch 'master'.

KNewPasswordWidget: don't hide visibility action in plaintext mode

Summary:
Otherwise the user cannot tell whether what's going to be typed will be
visible or not. Same fix as in D5312.

Reviewers: cfeck

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D5530

M  +18   -0    autotests/knewpasswordwidgettest.cpp
M  +1    -0    autotests/knewpasswordwidgettest.h
M  +1    -1    src/knewpasswordwidget.cpp

https://commits.kde.org/kwidgetsaddons/6976a54f235544575994b77ab86a561d537187e7

--- Comment #11 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 8a1c758516fd606bce23dd92934d899f119ac49f by Elvis Angelaccio.
Committed on 20/04/2017 at 21:34.
Pushed by elvisangelaccio into branch 'master'.

KPasswordDialog: don't hide visibility action in plaintext mode

Summary:
Otherwise the user cannot tell whether what's going to be typed will be
visible or not.
FIXED-IN: 5.34

Reviewers: cfeck, fvogt

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D5312

M  +1    -0    autotests/CMakeLists.txt
A  +47   -0    autotests/kpassworddialogautotest.cpp     [License: LGPL (v2+)]
A  +34   -0    autotests/kpassworddialogautotest.h     [License: LGPL (v2+)]
M  +2    -1    src/kpassworddialog.cpp

https://commits.kde.org/kwidgetsaddons/8a1c758516fd606bce23dd92934d899f119ac49f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to