https://bugs.kde.org/show_bug.cgi?id=378909
--- Comment #2 from RJVB <rjvber...@gmail.com> ---
Ah, that's because
```
void PatchReviewPlugin::setPatch( IPatchSource* patch ) {
//...
if( m_patch ) {
disconnect( m_patch.data(), &IPatchSource::patchChanged, this,
&PatchReviewPlugin::notifyPatchChanged );
if ( qobject_cast<LocalPatchSource*>( m_patch ) ) {
// make sure we don't leak this
// TODO: what about other patch sources?
m_patch->deleteLater();
```
As far as I recall there's a fallback m_patch instance which should never be
deleted. If that's still correct shouldn't this code deleteLater all m_patch
instances except when they're of the type of the fallback?
At the very least `VCSDiffPatchSource` instances should be deleted, I guess.
Will test.
--
You are receiving this mail because:
You are watching all bug changes.
