https://bugs.kde.org/show_bug.cgi?id=377050

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-framework/1387b5efe31e3
                   |                            |30777c8ffd9029f79063cc7a7a9
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 1387b5efe31e330777c8ffd9029f79063cc7a7a9 by David Edmundson.
Committed on 13/04/2017 at 09:49.
Pushed by davidedmundson into branch 'master'.

Guard against Applet not loading AppletInterface

Summary:
This can happen if an applet has invalid metadata, it doesn't have a
script engine set (X-Plasma-API) so it won't load the DeclarativeAppletScripts
Having invalid metadata could come from the applet, or from the fallback applet
created in Containment::Private::createApplet.

We guard against it in appletAdded but not in appletRemoved, which is
inconsistent. We also apparently must have guards elsewhere otherwise
we'd see the crash more.

Test Plan: Had corrupt applet, used to crash, now doesn't

Reviewers: #plasma

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D5423

M  +6    -3    src/scriptengines/qml/plasmoid/containmentinterface.cpp

https://commits.kde.org/plasma-framework/1387b5efe31e330777c8ffd9029f79063cc7a7a9

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to