https://bugs.kde.org/show_bug.cgi?id=378529
Bug ID: 378529
Summary: KPackage does not ignore warnings during appdata
generation
Product: frameworks-kpackage
Version: 5.32.0
Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
Severity: major
Priority: NOR
Component: default
Assignee: notm...@gmail.com
Reporter: fab...@ritter-vogt.de
Target Milestone: ---
Due to $SUBJECT building various parts of Plasma 5.8 which use the removed
Plasma/PopupApplet service type do not build correctly. The bug is in
KF5PackageMacros.cmake, around line 53:
execute_process(COMMAND ${kpackagetool_cmd} --appstream-metainfo
${CMAKE_CURRENT_SOURCE_DIR}/${dir} OUTPUT_FILE ${APPDATAFILE} ERROR_VARIABLE
appstreamerror RESULT_VARIABLE result)
if(appstreamerror)
if (NOT result EQUAL 0)
message(WARNING "couldn't generate metainfo for ${component}:
${appstreamerror}")
endif ()
else()
install(FILES ${APPDATAFILE} DESTINATION
${KDE_INSTALL_METAINFODIR})
endif()
In the failing case appstreamerror is not empty, as it emits warnings, but the
file is still generated successfully, result is 0.
This means that:
* No error or warning is printed
* The file is generated but not installed
This needs to be fixed like this, IMO:
execute_process(COMMAND ${kpackagetool_cmd} --appstream-metainfo
${CMAKE_CURRENT_SOURCE_DIR}/${dir} OUTPUT_FILE ${APPDATAFILE} ERROR_VARIABLE
appstreamerror RESULT_VARIABLE result)
if (NOT result EQUAL 0)
message(WARNING "couldn't generate metainfo for ${component}:
${appstreamerror}")
else()
if(appstreamerror)
message(WARNING "warnings during generation of metainfo for
${component}: ${appstreamerror}")
install(FILES ${APPDATAFILE} DESTINATION
${KDE_INSTALL_METAINFODIR})
endif()
--
You are receiving this mail because:
You are watching all bug changes.
