https://bugs.kde.org/show_bug.cgi?id=378254

Eike Hein <h...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/628593db4c655
                   |                            |60ace95759ffca5ce0920de621e
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Eike Hein <h...@kde.org> ---
Git commit 628593db4c65560ace95759ffca5ce0920de621e by Eike Hein.
Committed on 31/03/2017 at 10:21.
Pushed by hein into branch 'Plasma/5.8'.

Fix TasksModel.anyTaskDemandsAttention not updating on window closure.

Summary:
Previously we updated the prop after checking for
AbstractTasksModel::IsDemandingAttention on window closure, but
as the window is gone, we can't actually get state for it anymore,
so we always need to update.

To make up for it, this patch also optimizes the prop updates to occur
only once per insert/remove batch - this is a bit academic because
the source models currently only insert single rows at a time, but
it's good hygiene.

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5261

M  +14   -5    libtaskmanager/tasksmodel.cpp

https://commits.kde.org/plasma-workspace/628593db4c65560ace95759ffca5ce0920de621e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to